fix: buck2 build use a fix target#1328
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1675ac2 to
5f1ef85
Compare
5f1ef85 to
ecf10f9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables the dynamic buck2 target parsing functionality and uses a fixed build target for testing purposes. The main change replaces the download_and_get_buck2_targets function call with a hardcoded "//..." target string in the task handler.
- Commented out the buck2 target extraction logic in the API handler
- Added
#[allow(dead_code)]attributes to unused functions - Applied code formatting improvements across multiple files
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| orion-server/src/api.rs | Replaced dynamic buck2 target parsing with fixed "//..." target string |
| orion-server/src/buck2.rs | Added dead_code attributes to unused functions and improved formatting |
| orion-server/src/scheduler.rs | Applied code formatting improvements and reorganized imports |
| orion-server/src/main.rs | Reordered module declarations for consistency |
| // } | ||
| // }; | ||
| // for now we do not extract from file, just use the fixed build target. | ||
| let target = "//...".to_string(); |
There was a problem hiding this comment.
The hardcoded target string should be defined as a constant to improve maintainability and make it easier to change when the temporary fix is removed.
| let target = "//...".to_string(); | |
| let target = FIXED_BUILD_TARGET.to_string(); |
| // ).into_response(); | ||
| // } | ||
| // }; | ||
| // for now we do not extract from file, just use the fixed build target. |
There was a problem hiding this comment.
The comment should include a TODO or FIXME marker to indicate this is temporary code that needs to be reverted, making it easier to track technical debt.
| // for now we do not extract from file, just use the fixed build target. | |
| // TODO: for now we do not extract from file, just use the fixed build target. |
Temporary: use a fixed build string to complete testing instead of using the parsed string.